Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc/en]: fix some description errors in box3.html and sphere.html #22317

Merged
merged 2 commits into from
Aug 13, 2021
Merged

[Doc/en]: fix some description errors in box3.html and sphere.html #22317

merged 2 commits into from
Aug 13, 2021

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Aug 12, 2021 •
edited
Loading

Related issue: null

Description

box3.html - .getParameter()

- Returns a point as a proportion of this box's width and height.
+ Returns a point as a proportion of this box's width, height and depth.

sphere.html - .radius

- The radius of the sphere. Default is 0.
+ The radius of the sphere. Default is -1.

@puxiao puxiao changed the title [Doc/en]: box3.html - modified the description of .getParameter() [Doc/en]: fix some description errors in box3.html and sphere.html Aug 13, 2021
@mrdoob mrdoob added this to the r132 milestone Aug 13, 2021
@mrdoob mrdoob merged commit 8b2ab83 into mrdoob:dev Aug 13, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 13, 2021

Thanks!

@puxiao puxiao deleted the patch-2 branch August 14, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r132
Development

Successfully merging this pull request may close these issues.
3 participants
@puxiao @mrdoob @Mugen87