Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Update the Schlick formula signature #22316

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

WestLangley
Copy link
Collaborator

This PR reverts a change made in #22156, which introduced F90 as a vec3. We only support monochromatic F90, so that variable is changed to a float.

This also avoids having to instantiate a vec3 when the Schlick method is called.

Unity and Filament also consider F0 as a vec3 and F90 as a float.

@WestLangley WestLangley added this to the r132 milestone Aug 11, 2021
@WestLangley WestLangley changed the title Shaders: Update the Schlick formula signatur Shaders: Update the Schlick formula signature Aug 11, 2021
@mrdoob mrdoob merged commit 528ada0 into mrdoob:dev Aug 11, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 11, 2021

Thanks!

@WestLangley WestLangley deleted the dev_schlick branch August 11, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants