-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshStandardMaterial: Remove roughness-dependent Fresnel from environment lighting #22308
Conversation
Even with this change, CI passed for me. We'll see what happens... :-) |
Curious to see! 👀 |
Thanks! |
It's pretty subtle in general, but I can see the change in the helmet:
@elalish this will probably affect https://modelviewer.dev/fidelity/ |
It's surprising that the e2e ci hasn't noticed any change... 😶 |
As in #16559 (comment), it's specially noticeable in the tubes behind the helmet:
|
Looking good! ✨ |
Thanks for the diligence, @WestLangley! I'm working on updating our fidelity tests, so I'll be able to give better feedback soon, but I agree with @mrdoob's analysis. |
Correction to #15644 and #16559.
The sample code in the paper is not consistent with the derivation in the paper.
The derivation uses specular reflectance
F0
, the code used fresnelF
.This discrepancy has been noted elsewhere.