Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyBinding: Fix _getValue_direct(). #22290

Merged
merged 1 commit into from
Aug 9, 2021
Merged

PropertyBinding: Fix _getValue_direct(). #22290

merged 1 commit into from
Aug 9, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 7, 2021

Related issue: see https://discourse.threejs.org/t/material-opacity-set-to-nan-after-animation-stops/28695

Description

_getValue_direct() used the wrong reference for accessing the target object's value. The implementation is now aligned to _setValue_direct().

@Mugen87 Mugen87 added this to the r132 milestone Aug 7, 2021
@mrdoob mrdoob merged commit 49dd5f1 into mrdoob:dev Aug 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants