Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: F_Schlick dotLH -> dotVH #22288

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

WestLangley
Copy link
Collaborator

For consistency with #21927, these changes are warranted.

/ping @sunag Note dotLH = dotVH, so this change is for semantics only.

@WestLangley WestLangley added this to the r132 milestone Aug 6, 2021
@sunag
Copy link
Collaborator

sunag commented Aug 6, 2021

Thank you for letting me know . Currently it is like this for new NodeMaterial system:

vec3 halfDir = normalize( lightDirection + PositionViewDirection );
//float dotNL = saturate( dot( NormalView, lightDirection ) );
//float dotNV = saturate( dot( NormalView, PositionViewDirection ) );
float dotNH = saturate( dot( NormalView, halfDir ) );
float dotLH = saturate( dot( lightDirection, halfDir ) );
vec3 F = F_Schlick( specularColor, dotLH );

But I can update too.

@WestLangley WestLangley merged commit bf3e926 into mrdoob:dev Aug 9, 2021
@WestLangley
Copy link
Collaborator Author

Merging for now... I hope that is OK...

@WestLangley WestLangley deleted the dev_shaders_schlick branch August 9, 2021 11:42
@mrdoob
Copy link
Owner

mrdoob commented Aug 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants