Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLShadowMaps: Add support for rendering shadows with displacement maps #22287

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Aug 6, 2021

Related issue: --

Description

Adds support for correctly rendering shadows for geometry with displacement maps automatically so customDepthMaterial and customDistanceMaterial are no longer needed for displacement map materials.

BEFORE AFTER
image image

@gkjohnson gkjohnson closed this Aug 6, 2021
@gkjohnson gkjohnson reopened this Aug 6, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 9, 2021

Excellent!

@WestLangley WestLangley added this to the r132 milestone Aug 16, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 20, 2021

@mrdoob I guess this PR can be merged, too. 😇

@mrdoob mrdoob merged commit 6cca448 into mrdoob:dev Aug 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants