Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshNormalMaterial: rename vertex and fragment shaders #22277

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

WestLangley
Copy link
Collaborator

Adhering to the three.js nomenclature conventions, this PR renames the MeshNormalMaterial shaders as follows:

normal_vert.glsl.js -> meshnormal_vert.glsl.js

normal_frag.glsl.js -> meshnormal_frag.glsl.js

This is consistent with meshbasic_vert.glsl.js, etc.

It also prevents confusion with normal_vertex.glsl.js and related shader chunks.

@WestLangley WestLangley added this to the r132 milestone Aug 5, 2021
@mrdoob mrdoob merged commit f3b07cf into mrdoob:dev Aug 5, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 5, 2021

Thanks!

@WestLangley WestLangley deleted the dev_meshnormal branch August 5, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants