-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Removed webgl_loader_gltf_extensions #22276
Conversation
I think it's also better to have examples for showcasing just a single extension rather than |
Plenty of other glTF examples without these, agreed! I think this example had become too long/complex to be useful anyway. |
I also do not think it is a good idea to have use cases (i.e., extensions) hidden behind GUI menu items, because CI will not test it. |
Yeah, Now, some glTF extensions (specular-glossiness, unlit, and lights?) are not in our examples (let me know if I'm wrong). it would be good to somehow test them in |
I've heard they're trying to deprecate specular-glossiness. |
Yeah, glTF has specular extension now. So off topic, I'm personally thinking of moving specular-glossiness extension support to my https://github.com/takahirox/three-gltf-extensions repo. |
I don't think it is necessary that examples exist for every glTF extension. Creating unit tests for them would be ideal. The GLB used for https://threejs.org/examples/?q=unreal#webgl_postprocessing_unreal_bloom could probably be switched to unlit though (
Let's start an issue about this, there may be a few options and considerations here. |
That sounds good to me 👍 |
Hm I tested this out, but it turns out the |
Description
I think, at this point, these models make gltf look bad 🙈