Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loaders: Use HalfFloatType as default texture type. #22265

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Loaders: Use HalfFloatType as default texture type. #22265

merged 1 commit into from
Aug 4, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 4, 2021

Related issue: Fixed #22226.

Description

Use THREE.HalfFloatType in RGBELoader, HDRCubeTextureLoader and EXRLoader for better device compatibilty.

@Mugen87 Mugen87 requested a review from WestLangley August 4, 2021 07:45
WestLangley
WestLangley approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@WestLangley WestLangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot. :-)

@mrdoob mrdoob added this to the r132 milestone Aug 4, 2021
@mrdoob mrdoob merged commit 48b6a3c into mrdoob:dev Aug 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 4, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Aug 4, 2021

Seems like this fixed both iOS Safari 14 and iOS Safari 15! 💯

mrdoob pushed a commit that referenced this pull request Aug 4, 2021
@Mugen87 @mrdoob
Loaders: Use HalfFloatType as default texture type. (#22265)
87128ef
@mrdoob
Copy link
Owner

mrdoob commented Aug 4, 2021

Published 0.131.3 with this change.

mrdoob pushed a commit that referenced this pull request Aug 4, 2021
@Mugen87 @mrdoob
Loaders: Use HalfFloatType as default texture type. (#22265)
8390f09
@donmccurdy donmccurdy mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WestLangley WestLangley WestLangley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r132
Development

Successfully merging this pull request may close these issues.

Transmission examples not working on Galaxy M30
3 participants
@Mugen87 @mrdoob @WestLangley