WebXRManager: Clear state and added some accessor functions #22260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with main repo
mrdoob
reviewed
Aug 3, 2021
src/renderers/webxr/WebXRManager.js
Outdated
|
|
||
| }; | ||
|
|
||
| this.getxrFrame = function () { |
There was a problem hiding this comment.
Isn't frame available already in the onAnimationFrame() callback?
There was a problem hiding this comment.
Yes, but then it has to be passed into the components that would like to have access.
For instance, I was experimenting with creating a cube layer for the background and it was handy to have it available on the xr object.
There was a problem hiding this comment.
@mrdoob I can remove it if you prefer
There was a problem hiding this comment.
I see...
How about following the naming pattern of the other methods and call it getFrame()?
mrdoob
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the state wasn't cleaned up in the WebXR manager which could lead to errors.
Also added some helper to give easier access to WebXR state
This contribution is funded by Oculus.