MeshMatcapMaterial: Add support for vertex tangents #22248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why am I getting all these extra commits? :/ |
|
The squash and merge option creates new commits which are different compared to the original ones. Hence, I create new branches for a feature or force-push to the latest commit on |
|
I assume this is mergeable... Hopefully I fixed it for future PRs with |
Mugen87
approved these changes
Aug 3, 2021
|
Thanks! |
mrdoob
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Clean up * Added vertex tangent support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22245.