WebGLRenderer: Ensure program properties are booleans. #22244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CLVNSwan Would appreciate a second pair of eyes that can validate this fix 👍 . |
|
@mrdoob I guess this hotfix should be cherry-picked to |
|
@Mugen87 The fix worked for me 👍 Thank you! 😊 |
|
This solved my performance issue as well. Thank you! |
No worries! 👍 |
|
Thanks! |
mrdoob
pushed a commit
that referenced
this pull request
Aug 3, 2021
|
Cherry picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #22242
Description
Unfortunately certain checks in
WebGLRendererandWebGLProgramsadded inr131due to the removal of certain material properties introduce a performance regression sincegetProgram()is called too often. That happens because flags inWebGLProgramsandWebGLRendererdid not have the same type (boolean) so comparison always failed.