Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader: check for null textures #22239

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

camnewnham
Copy link
Contributor

Related issue: #22114

Description

On testing with a series of further FBX files from various software, there are also occasions where the texture is not defined when returning from the textureMap. This fix requires both texture and texture.image to be defined, or returns undefined.

Apologies for not catching it in the earlier PR.

If older syntax is preferred this can be expanded to texture !== undefined && texture.image !== undefined.

@camnewnham camnewnham changed the title Fbxloader null textures FBXLoader: check for null textures Aug 2, 2021
@mrdoob mrdoob added this to the r132 milestone Aug 2, 2021
@mrdoob mrdoob merged commit a78005a into mrdoob:dev Aug 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 2, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Aug 2, 2021

If older syntax is preferred this can be expanded to texture !== undefined && texture.image !== undefined.

a49cd80

@camnewnham camnewnham deleted the fbxloader-null-textures branch August 6, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants