-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update dispose return type #22237
Conversation
I think it should be |
Then it's best if the OP corrects the other methods, too. |
Oh... I guess we have many incorrect ones like that? |
Ye |
Yes, the docs are currently not consistent regarding returns types. If a method has not
I think I vote for using |
|
Before using |
These methods do not return |
So |
Then let's use @servinlp Are you willing to update the docs accordingly? |
I will update this PR first and then see if I can change the rest in a different PR. Do we have a document or something were we define documentation guide lines? |
No, if possible I would like to avoid that and just correct the existing doc pages. If everything is consistent, copy/paste errors like before can be avoided. |
Do you mind updating the Chinese pages, too? |
It looks like the Chinese pages don't have the documentation for the dispose method yet |
Thanks! |
Description
On multiple places change the documentation for the
dispose()
method to return null