Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Remove outdated code in Physical Material fragment shader #22234

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

WestLangley
Copy link
Collaborator

All non-PMREM environment maps assigned to a Physical material are now converted to PMREM CubeUV format automatically by the renderer.

Consequently, the shader code can be greatly simplified.

@WestLangley WestLangley added this to the r132 milestone Aug 1, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 2, 2021

Yay!

@mrdoob mrdoob merged commit a10f9ec into mrdoob:dev Aug 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants