Switch to native MSAA for WebXR #22230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
I wonder if we even need a WebGL1 code path... |
AFAIK, yes 😇 . |
|
WebGL 1.0 WebXR-related code paths can probably be safely removed once WebGL 2.0 is enabled by default on Safari/iOS devices, to prevent the unlikely scenario of WebXR support landing (looks like it's close) and WebGL 1.0 still being the default. It seems likely that those two would ship together though. |
|
I doubt WebXR will land in Safari any time soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change switches more code away from the old style WebXRLayer by relying on WebGL2 MSAA support.
I carefully coded this to avoid flushes of the AA data to main memory so it's just as fast as before.
I did notice that other parts of three.js are causing flushes. I will debug those separately.
This contribution is funded by Oculus.