Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fix const assignment. #22225

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Editor: Fix const assignment. #22225

merged 1 commit into from
Jul 30, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 30, 2021 •
edited
Loading

Related issue: -

Description

Minor clean up in Sidebar.Material.js. It seems the removed two lines are not required.

@mrdoob mrdoob added this to the r132 milestone Jul 30, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 30, 2021

Good catch.
I guess it'll be better to do let material = currentObject.material; though?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 30, 2021 •
edited
Loading

But what is the purpose of material = material[ currentMaterialSlot ]; when the local variable is not further used?

@mrdoob
Copy link
Owner

mrdoob commented Jul 30, 2021

Oh true. Please, ignore me 😅

@mrdoob mrdoob merged commit 9b1faf8 into mrdoob:dev Jul 30, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 30, 2021

Thanks!

mrdoob pushed a commit that referenced this pull request Jul 30, 2021
@Mugen87 @mrdoob
Editor: Fix const assignment. (#22225)
b55a8ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r132
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob