Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Removed webgl_materials_shaders_fresnel. #22215

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Examples: Removed webgl_materials_shaders_fresnel. #22215

merged 1 commit into from
Jul 29, 2021

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jul 29, 2021

Description

I think this example may confuse people now that we have transmission/thickness.

Screenshot 2021-07-29 at 17 07 25

@mrdoob mrdoob added this to the r132 milestone Jul 29, 2021
@mrdoob mrdoob merged commit 229fee0 into dev Jul 29, 2021
@mrdoob
Copy link
Owner Author

mrdoob commented Jul 29, 2021

@WestLangley What should we do with CubeRefractionMapping, EquirectangularRefractionMapping and CubeUVRefractionMapping?

@WestLangley
Copy link
Collaborator

@mtdoob

FWIW, I always thought that Cube/EquirectMapping and Reflection/RefractionMapping should be decoupled....

What should we do with CubeRefractionMapping, EquirectangularRefractionMapping and CubeUVRefractionMapping?

Hmm... I'm not sure yet...

@mrdoob mrdoob deleted the cleanup branch July 30, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants