Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshPhysicalMaterial: Renamed attenuationColor to attenuation #22206

Merged
merged 1 commit into from
Jul 28, 2021
Merged

MeshPhysicalMaterial: Renamed attenuationColor to attenuation #22206

merged 1 commit into from
Jul 28, 2021

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jul 28, 2021

Related issue: #22156

Description

We do not have any *Color property. Seems like attenuation is more appropriate.

@WestLangley Should it be attenuationTint instead?

@mrdoob mrdoob added this to the r131 milestone Jul 28, 2021
@mrdoob
Copy link
Owner Author

mrdoob commented Jul 28, 2021

Merging this for now...

@mrdoob mrdoob merged commit 6249aaa into dev Jul 28, 2021
@mrdoob mrdoob deleted the attenuation branch July 28, 2021 18:12
@mrdoob
Copy link
Owner Author

mrdoob commented Jul 28, 2021

/fyi @takahirox

@WestLangley
Copy link
Collaborator

@mrdoob

specularTint is a tinting of the monochromatic specular reflectance.

//

"attenuation Color" the hue shift of white light as it passes through a medium.

I assume, the attenuation would be applied to the light source of any color.

In that case, I think attenuationTint is best, because it is tinting the light color.

@WestLangley
Copy link
Collaborator

transmissionTint ?

@mrdoob
Copy link
Owner Author

mrdoob commented Jul 28, 2021

There's also attenuationDistance.... so attenuationTint sounds good to me 👍

@mrdoob mrdoob mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r131
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdoob @WestLangley