Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader: Increase sampling for nurbs geometries. #22202

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 28, 2021

Related issue: Fixed #22198.

Description

As suggested in #22198 (comment), slightly increasing the sampling rate fixes glitches in context of NURBS.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 28, 2021

It seems the previous value 7 was already an increase compared to the original value of 1.5. https://github.com/mrdoob/three.js/pull/10758/files#diff-d6785bd34a82e05dbb309d20596bf4bf8d8e31e3c7e128fb0917fdebe36a9006R416.

@mrdoob mrdoob added this to the r131 milestone Jul 28, 2021
@mrdoob mrdoob merged commit 45df862 into mrdoob:dev Jul 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 28, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple four-point NURBS Curve is interpreted badly.
2 participants