Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Revert to manual PMREMGenerator usage. #22199

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 27, 2021

Related issue: Fixed #22197.

Description

If an app wants to debug a cubeUV map, it's better when PMREMGenerator is used in app level code. The internal implementation is not flexible enough and I would not enhance it just for the purpose of visualizing the preprocessed env map.

@Mugen87 Mugen87 added this to the r131 milestone Jul 27, 2021
@WestLangley
Copy link
Collaborator

If an app wants to debug a cubeUV map, it's better when PMREMGenerator is used in app level code.

No it is not.

The internal implementation is not flexible enough and I would not enhance it just for the purpose of visualizing the preprocessed env map.

What???. This is fixable. The point is to remove PMREM from the app level.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 28, 2021

Visualizing the env map like in the example is no valid use case to me. The code assigns it to the map property which is obviously not the intended way of using the env map produced by PMREMGenerator. It's a hack for debugging and I would not build an API around that. Using PMREMGenerator on app level for this particular use case is fine.

@mrdoob
Copy link
Owner

mrdoob commented Jul 28, 2021

I agree with @Mugen87. And I think this is a good reason for not removing PMREMGenerator from the public API.

@mrdoob mrdoob merged commit dd69eba into mrdoob:dev Jul 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 28, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PMREM Debug Map Regression
3 participants