Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ldraw example update #22191

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Ldraw example update #22191

merged 4 commits into from
Jul 27, 2021

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Jul 27, 2021

Related issue: #22188

Description

  • Fix some lint issues in webgl_loader_ldraw (double quotes -> single quotes).
  • Remove outputEncoding = sRGBEncoding because the the loaded LDraw colors are sRGB.
  • Remove envMapIntensity: 0.3 from LDraw material.
  • Revert to use RoomEnvironment (and remove LDrawEnvironment) which is now bright enough with the above change.
BEFORE AFTER
image image

And for some more context here's how it would look if everything were converted to Linear color before rendering to sRGB output with ACES tone mapping:

cc @WestLangley

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 27, 2021

Seems the E2E screenshot for the example needs an update.

@mrdoob
Copy link
Owner

mrdoob commented Jul 27, 2021

I'll merge and regenerate the screenshot.

@mrdoob mrdoob merged commit 74bff46 into mrdoob:dev Jul 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 27, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jul 27, 2021

@gkjohnson

And for some more context here's how it would look if everything were converted to Linear color before rendering to sRGB output with ACES tone mapping:

That looks very good!

@gkjohnson gkjohnson deleted the ldraw-example-update branch July 27, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants