Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDrawLoader: Wrap Conditonal Line Material, remove "canHaveEnvMap" field #22183

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

gkjohnson
Copy link
Collaborator

Related issue: --

Description

Wraps the conditional line material with a class so modifying opacity and color are consistent with other materials and removes canHaveEnvMap field because I don't believe it's needed.

cc @yomboprime

@mrdoob mrdoob added this to the r131 milestone Jul 26, 2021
@mrdoob mrdoob merged commit a056753 into mrdoob:dev Jul 26, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 26, 2021

Thanks!

@gkjohnson gkjohnson deleted the simplify-conditional-shader branch July 31, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants