Fix color attribute initialization of InstancedMesh #22171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22170
Description
Color attribute of InstancedMesh is not initialized on the constructor but when first calling
setColorAt()
, and it creates the BufferAtribute with the current count value, which can be lower than the initial one. This leads to issues if the count is increased after.This PR saves the maximum count to later correctly initialize the color BufferAtribute.