Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for foveation #22162

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add support for foveation #22162

merged 1 commit into from
Jul 27, 2021

Conversation

cabanier
Copy link
Contributor

@cabanier cabanier commented Jul 20, 2021 •
edited by mrdoob
Loading

Closes #22161

Add support for fixed foveation for WebXR experiences.

This contribution is funded by Oculus.

@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2021

Does this need optionalFeatures: ['high-fixed-foveation-level']?

And, just so I understand...
Setting fixedFoveation to 1 means that all the sections of the frame will render at full resolution, right?

image

@mrdoob mrdoob added this to the r131 milestone Jul 20, 2021
@cabanier
Copy link
Contributor Author

cabanier commented Jul 20, 2021 •
edited
Loading

Does this need optionalFeatures: ['high-fixed-foveation-level']?

No. That's an non-standard Oculus-only option.

And, just so I understand...
Setting fixedFoveation to 1 means that all the sections of the frame will render at full resolution, right?

It's the opposite.
0 = no foveation = full resolution
1 = maximum foveation = the edges render at lower resolution

@cabanier
Copy link
Contributor Author

Most native apps set foveation to the maximum. Should we do the same in three?

@mrdoob mrdoob merged commit ee1812f into mrdoob:dev Jul 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 27, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jul 27, 2021

@cabanier

Most native apps set foveation to the maximum. Should we do the same in three?

Sounds good to me 👍

@mrxz mrxz mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r131
Development

Successfully merging this pull request may close these issues.

Add support for foveation to WebXRManager
2 participants
@cabanier @mrdoob