Fix the webaudio sandbox example in Safari #22149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, the example works now in Safari, too 👍 . The only thing I have noticed is some sporadic/rare noise sounds and cracks (at the application start and when moving/looking around). Tested with Safari 14 on macOS. Latest Chrome and Firefox don't show this issue. If others can reproduce we might want to report this to the WebKit bug tracker: https://bugs.webkit.org/ |
Mugen87
approved these changes
Jul 19, 2021
|
Yes, the issue with noise/distortion is a current bug with PannerNode in Safari https://bugs.webkit.org/show_bug.cgi?id=227199 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari doesn't support ogg audio. This PR changes the webaudio sandbox example to use an <audio> element as a sound source with both mp3 and ogg formats.