Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add support for PLY point clouds. #22138

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Editor: Add support for PLY point clouds. #22138

merged 4 commits into from
Jul 16, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 15, 2021

Related issue: Fixed #22133

Description

The implementation of detecting point clouds is similar to how drc files are processed.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 15, 2021

Can we avoid the linter warning 'XRWebGLLayer' is not defined by adding XRWebGLLayer to this section in package.json?

three.js/package.json

Lines 41 to 48 in c97a3e5

"globals": {
"potpack": true,
"fflate": true,
"ZSTDDecoder": true,
"bodymovin": true,
"OIMO": true,
"Stats": true
},

@WestLangley WestLangley added this to the r131 milestone Jul 15, 2021
editor/js/Loader.js Outdated Show resolved Hide resolved
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 15, 2021

Can we avoid the linter warning 'XRWebGLLayer' is not defined by adding XRWebGLLayer to this section in package.json?

Let's give this a try d7a756a, ad8c600.

@mrdoob mrdoob merged commit a1b4086 into mrdoob:dev Jul 16, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 16, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jul 16, 2021

Can we avoid the linter warning 'XRWebGLLayer' is not defined by adding XRWebGLLayer to this section in package.json?

Let's give this a try d7a756a, ad8c600.

@marcofugaro Is that the right way of doing it?

@marcofugaro
Copy link
Contributor

Yup, correct 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Support for PLY point clouds
4 participants