SVGLoader: fix round rects when only rx or ry is specified #22124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation handles
rect
rounded corners incorrectly when eitherrx
orry
attr is omitted.Here’s a SVG made in Inkscape where only
rx
is specified:round-rect.svg.zip
Here’s how a browser renders it:
Here’s how THREE.js loads it without the fix:
And here’s how THREE.js loads it with the fix:
Indeed, the standard says:
The same applies to
ry