Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug that thicknessMap is not loaded correctly in the shader #22116

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix a bug that thicknessMap is not loaded correctly in the shader #22116

merged 1 commit into from
Jul 12, 2021

Conversation

takahirox
Copy link
Collaborator

Description

This PR fixes a bug that thicknessMap is not loaded correctly in the shader

@takahirox takahirox mentioned this pull request Jul 12, 2021
Merged
@mrdoob mrdoob added this to the r131 milestone Jul 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 12, 2021

I bet this took a while to find out... 😬

@mrdoob mrdoob merged commit 5a33c56 into mrdoob:dev Jul 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 12, 2021

Thanks!

@takahirox takahirox deleted the FixThicknessMap branch July 12, 2021 15:54
@takahirox
Copy link
Collaborator Author

I bet this took a while to find out... 😬

Exactly yes! How did you know that.... hehe

@mrdoob
Copy link
Owner

mrdoob commented Jul 12, 2021

I've been there... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r131
Development

Successfully merging this pull request may close these issues.
3 participants
@takahirox @mrdoob @donmccurdy