Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix links in OrbitControls #22101

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Docs: fix links in OrbitControls #22101

merged 2 commits into from
Jul 9, 2021

Conversation

vsh
Copy link
Contributor

@vsh vsh commented Jul 8, 2021

References to methods saveState & reset used method instead of page
Leading to broken sections
image

@Mugen87 Mugen87 added this to the r131 milestone Jul 9, 2021
@mrdoob mrdoob merged commit fc17d78 into mrdoob:dev Jul 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 9, 2021

Thanks!

Ridwanullahi-super
Ridwanullahi-super approved these changes Jul 9, 2021
View reviewed changes
Copy link

@Ridwanullahi-super Ridwanullahi-super left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good.

@vsh vsh deleted the fix-docs-orbit-controls branch August 21, 2021 08:58
@vsh vsh restored the fix-docs-orbit-controls branch August 21, 2021 09:08
@vsh vsh deleted the fix-docs-orbit-controls branch August 21, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ridwanullahi-super Ridwanullahi-super Ridwanullahi-super approved these changes

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r131
Development

Successfully merging this pull request may close these issues.
4 participants
@vsh @mrdoob @Mugen87 @Ridwanullahi-super