Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WireframeGeometry: Prevent duplicate edges. #22097

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 7, 2021

Related issue: Fixed #22094.

Description

WireframeGeometry checks now for unique edges by comparing vertex data.

@WestLangley WestLangley added this to the r131 milestone Jul 7, 2021
@WestLangley
Copy link
Collaborator

This is working for me. Thanks!

@WestLangley
Copy link
Collaborator

@Mugen87 Are you aware of a reason why EdgesGeometry requires a vertex precision test?

@mrdoob
Copy link
Owner

mrdoob commented Jul 7, 2021

Beautiful~!

@mrdoob mrdoob merged commit cf38d5b into mrdoob:dev Jul 7, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jul 7, 2021

Thanks!

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 7, 2021

Are you aware of a reason why EdgesGeometry requires a vertex precision test?

I guess the original author wanted to honor #22094 (comment) 🤷.

@WestLangley
Copy link
Collaborator

EdgesGeometry's hard-wired precisionPoints breaks small geometries.

Would you be willing to apply your fix to EdgesGeometry, too -- removing the rounding?

That way, WireframeGeometry and EdgesGeometry would produce similar results.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 7, 2021

Aligning the implementations sounds good. Let me file a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WireframeGeometry generates duplicate edges
3 participants