Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Improved transmission example #22054

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Jun 28, 2021

Added material.reflectivity to the GUI.

I also commented out the annoying spinning, so we can determine if the code is working properly.

The animation loop could be removed in a future PR, or we could add an animate toggle to the GUI.

@WestLangley WestLangley added this to the r130 milestone Jun 28, 2021
@mrdoob mrdoob merged commit dd6ab3c into mrdoob:dev Jun 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 28, 2021

Thanks!

@WestLangley
Copy link
Collaborator Author

The animation loop could be removed in a future PR, or we could add an animate toggle to the GUI.

@mrdoob Preference?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 29, 2021

I vote to remove the animation loop 👍 .

@mrdoob
Copy link
Owner

mrdoob commented Jun 29, 2021

Yep! Me too 👍

@WestLangley WestLangley deleted the dev_transmission_example branch June 29, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants