Shaders: Clean up #22053
Merged
Shaders: Clean up #22053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jun 28, 2021
WestLangley
changed the title
|
@Mugen87 This is a bit complicated... The primary goal was clean up -- to set a consistent order. I did that. Afterwards, I had to change the The |
|
This can be merged. |
|
My earlier comment was referring to the fact that the shaders assume normals exist in the geometry. Of course, they don't always. That is a larger issue, and I do not think it should block this PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shader chunks are now in the same order as in other materials.