Examples: Clean up #22029

WestLangley · 2021-06-20T22:48:48Z

Follow-on to #21969, which removed the premultipliedAlpha test from webgl_materials_physical_transmission.html.

WestLangley · 2021-06-20T22:49:38Z

examples/webgl_materials_physical_transmission.html

@@ -65,7 +65,6 @@
 				renderer.outputEncoding = THREE.sRGBEncoding;

 				scene = new THREE.Scene();
-				scene.background = hdrEquirect;


Note: background was not removed. There were two backgrounds specified.

WestLangley · 2021-06-21T00:00:44Z

I am not a fan of these examples that rotate the object unnecessarily. They serve only to obfuscate potential problems.

I'd recommend a GUI to toggle-off the animation -- resetting the rotation to zero.

WestLangley · 2021-06-21T01:50:39Z

Updated screen shot is not correct... Not sure what is going on...

Mugen87 · 2021-06-21T07:40:03Z

Updated screen shot is not correct... Not sure what is going on...

Have you tried npm i before making the screenshot?

WestLangley · 2021-06-21T11:10:40Z

@Mugen87 I did, and the generated screenshot is still not correct. Can you give it a try?

mrdoob · 2021-06-21T11:57:04Z

@WestLangley can you try running npm i inside the test/ folder?

mrdoob · 2021-06-21T14:29:12Z

Thanks!

WestLangley · 2021-06-21T14:41:52Z

@WestLangley can you try running npm i inside the test/ folder?

Thanks! That fixed it.

Clean up

99b1e27

WestLangley commented Jun 20, 2021

View reviewed changes

mrdoob added this to the r130 milestone Jun 21, 2021

Update screenshot

a1c5831

mrdoob merged commit 1debe8b into mrdoob:dev Jun 21, 2021

WestLangley deleted the dev_examples branch June 21, 2021 14:43

Provide feedback