Editor: Store background in IndexedDB #22023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
commented
Jun 19, 2021
| @@ -131,8 +131,7 @@ Editor.prototype = { | |||
| this.scene.uuid = scene.uuid; | |||
| this.scene.name = scene.name; | |||
|
|
|||
| this.scene.background = ( scene.background !== null ) ? scene.background.clone() : null; | |||
There was a problem hiding this comment.
I can't remember why we were cloning scene.background.
There was a problem hiding this comment.
Maybe because scene.fog is cloned, too^^?
It seems the line was added like that right from the beginning: 750973b#diff-c7a0a223e819b2c4e36644546146290d9d14f241cf78daa5438faf335a2aff35R124
There was a problem hiding this comment.
Since you have changed the code, it makes sense to align:
Line 136 in 8d30d74
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #18479 #16154
Description
Store the background texture (and equirectangular texture) on IndexedDB.