Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrackballControls: Fully migrate to pointer events. #22006

Merged
merged 2 commits into from
Jun 25, 2021
Merged

TrackballControls: Fully migrate to pointer events. #22006

merged 2 commits into from
Jun 25, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 17, 2021 •
edited
Loading

Related issue: #21972

Description

Fully moves TrackballControls to pointer events.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 17, 2021 •
edited
Loading

https://raw.githack.com/Mugen87/three.js/e5513d5392815392f69ac79a7787205b0b347f01/examples/misc_controls_trackball.html

@Mugen87 Mugen87 marked this pull request as draft June 17, 2021 10:11
@Mugen87 Mugen87 marked this pull request as ready for review June 17, 2021 10:27
@Mugen87 Mugen87 changed the title TrackballControls: Filly migrate to pointer events. TrackballControls: Fully migrate to pointer events. Jun 17, 2021
@mrdoob mrdoob added this to the r130 milestone Jun 17, 2021
@mrdoob mrdoob merged commit 2c78502 into mrdoob:dev Jun 25, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 25, 2021

Thanks!

@vasturiano vasturiano mentioned this pull request Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r130
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob