Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set path to web-ifc.wasm in editor's IFCLoader #21993

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Set path to web-ifc.wasm in editor's IFCLoader #21993

merged 2 commits into from
Jun 16, 2021

Conversation

xawill
Copy link
Contributor

@xawill xawill commented Jun 15, 2021

Related issue: #21988

Description

See related issue.

@agviegas and I are pretty confident that this fixes the issue, but we don't know how to test it.

@mrdoob mrdoob added this to the r130 milestone Jun 16, 2021
@mrdoob mrdoob merged commit 8fd462d into mrdoob:dev Jun 16, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2021

Thanks!

mrdoob added a commit that referenced this pull request Jun 16, 2021
* Set path to web-ifc.wasm in editor's IFCLoader - Resolves #21988

* Update Loader.js

Co-authored-by: Mr.doob <[email protected]>
@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2021

Actually, the path was not quite right: 2272eae

@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2021

I've cherry-picked the change into the gh-pages branch and https://threejs.org/editor/ loads ifc files again 👍

@xawill
Copy link
Contributor Author

xawill commented Jun 16, 2021

Ah, ok, sorry about that. Thanks a lot for checking and releasing that fast! This will definitely help me with debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants