Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix Object3D.getObjectByProperty #21953

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Docs: Fix Object3D.getObjectByProperty #21953

merged 3 commits into from
Jun 10, 2021

Conversation

makc
Copy link
Contributor

@makc makc commented Jun 5, 2021

the ridiculous :Float misake has been pointed out like half a year ago, and yet nobody is fixing it, so...

@mrdoob mrdoob added this to the r130 milestone Jun 10, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 10, 2021

For consistency... Would it be okay if I change any to Any?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 10, 2021

Make sense! All other type definitions start with a captial.

@mrdoob mrdoob merged commit ee537cc into mrdoob:dev Jun 10, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 10, 2021

Thanks!

@mrdoob mrdoob changed the title fix getObjectByProperty docs Docs: Fix Object3D.getObjectByProperty Jun 10, 2021
@makc
Copy link
Contributor Author

makc commented Jun 10, 2021 •
edited
Loading

@mrdoob I kind of went with typescript any subconsciously. could have just used a * or removed a type entirely

@makc makc deleted the patch-2 branch June 10, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r130
Development

Successfully merging this pull request may close these issues.
3 participants
@makc @mrdoob @Mugen87