Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Tags: Add tags for example with GPU stats panel #21908

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #21509

Description

Add tags related to the GPU stats panel for the webgl_lines_fat example to make it more discoverable.

@WestLangley
Copy link
Collaborator

Hmmm. That example does not need an animation loop. Perhaps a different example would be a better choice?

@gkjohnson
Copy link
Collaborator Author

The GPU stats panel doesn't require a constantly running animation loop -- internally it continues to check on subsequent frames specifically so the on-demand rendering use case works without issue. And I chose the line_fat example because (at least on my lower end laptop) you can see GPU time differences when adjusting the material parameters. It consistently goes from 1ms to 2ms on my 2017 MS Surface Laptop when moving the line width between extremes. The GPU time would probably vary more if you could make the lines thicker. If there's another example you recommend that can easily toggle between intensive and less intensive in terms of GPU work I can add it there, too.

Also as noted here I would still like to increase the decimal precision of the displayed number so the affect of the material changes are more apparent, but that's for another PR.

@Mugen87 Mugen87 added this to the r130 milestone Jun 1, 2021
@Mugen87 Mugen87 merged commit 2843ac6 into mrdoob:dev Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants