Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderChunk: Fixed transmission crash when using flat shading #21897

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented May 27, 2021

Related issue: #21884

Description

The material wouldn't compile when enabling flat shading because vNormal was nor available.

Screen Shot 2021-05-27 at 9 34 35 AM

@takahirox FYI

@mrdoob mrdoob added this to the r129 milestone May 27, 2021
@mrdoob mrdoob merged commit 5be5267 into dev May 27, 2021
@mrdoob mrdoob deleted the transmission branch May 27, 2021 08:44
@takahirox
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants