WebGLRenderer: Workaround for copyTexImage2D in WebGL2 #21893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrussell
reviewed
May 26, 2021
|
|
||
| if ( capabilities.isWebGL2 ) { | ||
|
|
||
| // Workaround for https://bugs.chromium.org/p/chromium/issues/detail?id=1120100 |
There was a problem hiding this comment.
Is it worth leaving a TOFIX in here saying that once https://crbug.com/882580 is fixed, this workaround should be removed?
Hate to suggest it, but should this workaround be limited to Chrome?
There was a problem hiding this comment.
Is it worth leaving a TOFIX in here saying that once https://crbug.com/882580 is fixed, this workaround should be removed?
I'm subscribed to that bug. I'll remove the workaround as soon as it's fixed 👍
Hate to suggest it, but should this workaround be limited to Chrome?
It doesn't seem to break other browsers so I think I'll keep the code simple for now.
I can add more checks if we notice any regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves the the issue of RoughnessMipmapper breaking in WebGL2/Chrome/MacOS.