WebXRManager: Introduce updateCamera() and refactor getCamera(). #21886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
May 25, 2021
|
I like the change too 👍 |
mrdoob
reviewed
May 26, 2021
mrdoob
reviewed
May 26, 2021
| this.getCamera = function ( camera ) { | ||
| this.updateCamera = function ( camera ) { | ||
|
|
||
| if ( session === null ) return; |
|
@elalish I think this should solve your raycasting-in-ar issues. |
|
Thanks! |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #21002.
Description
Since the new XR hand examples use
getCamera()on app level, it's important to fix #21002 and avoid unnecessary computations whengetCamera()is called.Like suggested by @gkjohnson, the PR introduce a new flag
cameraAutoUpdateand a new update method that allows the app to perform the Kamera update manually. This is important to ensure up-to-date matrices so frame-late effects can be avoided.