Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve WebXRManager page. #21880

Merged
merged 1 commit into from
May 24, 2021
Merged

Docs: Improve WebXRManager page. #21880

merged 1 commit into from
May 24, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 23, 2021

Related issue: see #21869

Description

Adds some missing methods to the WebXRManager page.

@Mugen87 Mugen87 added this to the r129 milestone May 23, 2021
@gkjohnson
Copy link
Collaborator

gkjohnson commented May 24, 2021

This is related to #21188, as well, which requests a public way to get access to the xr camera and xr viewport resolution. By making this public the individual L and R are now exposed which make the xr viewport information available, too. Is there a clean way to document that do you think? Or perhaps a new XRCamera can be created that documents the extra field added to the L and R cameras?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 24, 2021

I'd like to focus this PR on adding the missing methods to the documentation. Please do not continue the discussion of #21188 in this PR.

@mrdoob mrdoob merged commit 3a549e1 into mrdoob:dev May 24, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 24, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants