Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL: gl.UNSIGNED_BYTE type for Uint8ClampedArray #21876

Merged
merged 1 commit into from
May 22, 2021
Merged

WebGL: gl.UNSIGNED_BYTE type for Uint8ClampedArray #21876

merged 1 commit into from
May 22, 2021

Conversation

0X-JonMichaelGalindo
Copy link
Contributor

Description

In the WebGLAttributes function, Uint8ClampedArray buffers were being treated as Float32Array.
The wrong type code was then being sent when uploading to the GPU.
Added line to check on buffer data creation.

@mrdoob mrdoob added this to the r129 milestone May 22, 2021
@mrdoob mrdoob merged commit c50649f into mrdoob:dev May 22, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 22, 2021

Thanks!

@0X-JonMichaelGalindo 0X-JonMichaelGalindo deleted the patch-1 branch May 22, 2021 18:20
@0X-JonMichaelGalindo
Copy link
Contributor Author

Thank you for ThreeJS! Happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants