Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update PlaneGeometry.html #21854

Merged
merged 2 commits into from
May 19, 2021
Merged

docs: Update PlaneGeometry.html #21854

merged 2 commits into from
May 19, 2021

Conversation

0b5vr
Copy link
Collaborator

@0b5vr 0b5vr commented May 19, 2021

Description

This PR makes a small change to https://threejs.org/docs/?q=planege#api/en/geometries/PlaneGeometry .

Arguments of code example is weird ( I believe ( 5, 20, 32 ) is weird), this PR fixes this.
I believe this change would be important since many people including beginners would see this docs.

Points need review

  • is ( 1, 1 ) a right choice?
    • by seeing BoxGeometry, I think 1x1 is good
    • I think we can just ditch segments for this example

Yutaka "FMS_Cat" Obuchi added 2 commits May 19, 2021 12:14
@mrdoob mrdoob added this to the r129 milestone May 19, 2021
@mrdoob mrdoob merged commit 5db6961 into mrdoob:dev May 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 19, 2021

Thanks!

@0b5vr 0b5vr deleted the docs-plane-geometry branch May 19, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants