Examples: Add package.json indicating jsm examples are modules #21838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #19575 (comment)
Description
As @donmccurdy suggested this adds a package.json file in
examples/jsm
to indicate that the contained files are es6 modules so they can be loaded correctly in node. In current master node will try (and fail) to load theexamples/jsm
files as commonjs because "type: module" is not present in the root package.json. Tested by making a test node project with npm and adding the file to thenode_modules/three/examples/jsm
folder.The true end of an era? Hopefully 🤞