Respect morph targets in OutlinePass #21836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #21790
Description
Prior to this pull request, the texture coordinates used to access the depth texture used to make the mask representing occluded vs non-occluded sections of selected objects were constructed using raw model vertex positions. The result of this was that models animated with morph targets would have outlines statically colored based on the positions of the pre-morphed vertices.
This pull request replaces the use of the unmodified vertex positions with the morphed vertex positions. As a result, the outline is correctly colored based on whether the current animated positions are occluded.
Linked examples of before and after (from the linked issue, where there are also static images):
Before: https://jsfiddle.net/Centipede5dev/q9kwpf4L/3
After: https://jsfiddle.net/yd6wo18z/9/