Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octree: Fix and optimize fromGraphNode(). #21834

Merged
merged 1 commit into from
May 17, 2021
Merged

Octree: Fix and optimize fromGraphNode(). #21834

merged 1 commit into from
May 17, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 14, 2021

Related issue: Fixed #21439.

Description

Octree.fromGraphNode() has several issues right now. It does not compute the world matrices of 3D object correctly and also performs too many redundant computations. Besides, geometries are cloned before toNonIndexed() is used although this is not necessary (since the method already creates a new geometry). And fromGraphNode() directly accesses the array property of buffer attributes which should never be done (since interleaved data are not supported that way).

@Mugen87 Mugen87 added this to the r129 milestone May 15, 2021
@mrdoob mrdoob merged commit db7851f into mrdoob:dev May 17, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 17, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octree.fromGraphNode cannot calculate scaled position when the mesh was in a group
2 participants