Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS3DRenderer: Support CSS3DSprite screen-space rotation #21823

Merged
merged 2 commits into from
May 13, 2021
Merged

CSS3DRenderer: Support CSS3DSprite screen-space rotation #21823

merged 2 commits into from
May 13, 2021

Conversation

WestLangley
Copy link
Collaborator

Fixes #21795.

@WestLangley WestLangley added this to the r129 milestone May 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 13, 2021

What do you think about CSS3DSprite.rotation2d instead?

@WestLangley
Copy link
Collaborator Author

What do you think about CSS3DSprite.rotation2d instead?

I think that is better. For consistency, perhaps CSS3DSprite.rotation2D?

@mrdoob
Copy link
Owner

mrdoob commented May 13, 2021

Sounds good 👍

@WestLangley WestLangley changed the title CSS3DRenderer: Introduce CSS3DSprite.spriteRotation CSS3DRenderer: Support CSS3DSprite screen-space rotation May 13, 2021
@mrdoob mrdoob merged commit f7b2c62 into mrdoob:dev May 13, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 13, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented May 13, 2021

Should we move sprite.material.rotation to sprite.rotation2D too? Or is that too messy?

@Mugen87
Copy link
Collaborator

Mugen87 commented May 13, 2021 •
edited
Loading

I vote to keep sprite.material.rotation for now until a solution for #21795 (comment) becomes more clear.

@WestLangley WestLangley deleted the dev_css3d_sprite_rotation branch May 13, 2021 16:06
@joshuaellis joshuaellis mentioned this pull request May 27, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.

CSS3DSprite rotation
3 participants
@WestLangley @mrdoob @Mugen87