UniformsLib: default color uniforms to white #21803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: --
Description
Perhaps there's a reason for this but if so it wasn't clear to me. The three "diffuse" color uniforms were defaulting to
0xeeeeeerather than white as I expected, at least. This isn't an issue with any of the built in materials because they all seem to explicitly set their initial value to0xffffff.examples/jsm/lines/LineMaterialdoes not, though, and uses the set of "line" uniforms from "UniformsLib" meaning the color is defaulting to the slightly off white color.